feat: refactor source file handling #1613
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upcoming features requires as to refactor some of our core modules. They are now more OOP friendly and some of the duplicated code from tool merging is now removed as well.
bhirsz
force-pushed
the
feat/refactor_source_handling
branch
3 times, most recently
from
d8e74d1 to
9dfb69d
Compare
Contributor
Performance Report
|
bhirsz
force-pushed
the
feat/refactor_source_handling
branch
from
9dfb69d to
e30e76c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored the codebase to improve code organization and maintainability. The main changes involve:
Code reorganization: Moved ConfigManager and GitIgnoreResolver classes from config.py to a new dedicated file config_manager.py
Version handling consolidation: Created new version_handling.py module to centralize version-related logic and constants
SourceFile introduction: Added new SourceFile dataclass to bundle file path, configuration, and model together
Variables module: Moved VariableMatches class to a new parsing/variables.py module for better code structure
Import cleanup: Removed unused imports and reorganized imports across multiple files
Test updates: Added semi-automatic trigger for performance tests - by adding 'performance' label performance tests will execute.
The
SourceFilewill be used in the upcoming refactors - for example to retain source lines. I did not want to include this refactor in this PR since it's already touching multiple different modules.